From 3b224458a5d539bbe00318d939c9a099f3f158e1 Mon Sep 17 00:00:00 2001 From: Charles Date: Tue, 4 Feb 2020 05:34:27 +0100 Subject: better parsing --- src/parse/parse_color.c | 32 +++++++++++++++++++------------- 1 file changed, 19 insertions(+), 13 deletions(-) (limited to 'src/parse/parse_color.c') diff --git a/src/parse/parse_color.c b/src/parse/parse_color.c index 5385c0c..d3cee05 100644 --- a/src/parse/parse_color.c +++ b/src/parse/parse_color.c @@ -6,7 +6,7 @@ /* By: cacharle +#+ +:+ +#+ */ /* +#+#+#+#+#+ +#+ */ /* Created: 2020/01/11 09:52:34 by cacharle #+# #+# */ -/* Updated: 2020/02/04 02:26:46 by cacharle ### ########.fr */ +/* Updated: 2020/02/04 05:12:42 by cacharle ### ########.fr */ /* */ /* ************************************************************************** */ @@ -14,42 +14,48 @@ t_bool parse_ceilling_color(t_state *state, char *line) { - int tmp; + long tmp; + errno = 0; state->ceilling_color.hexcode = 0x0; - if ((tmp = ft_atoi(line)) > 255 || tmp < 0) // cant do atoi due to overflow stuff, use ft_strtol + if ((tmp = ft_strtol(line, &line, 10)) > 255 || tmp < 0) return (FALSE); state->ceilling_color.rgb.r = (t_byte)tmp; - if ((line = ft_strchr(line, ',') + 1) == NULL) + if (*line++ != ',' || !ft_isdigit(*line)) return (FALSE); - if ((tmp = ft_atoi(line)) > 255 || tmp < 0) + if ((tmp = ft_strtol(line, &line, 10)) > 255 || tmp < 0) return (FALSE); state->ceilling_color.rgb.g = (t_byte)tmp; - if ((line = ft_strchr(line, ',') + 1) == NULL) + if (*line++ != ',' || !ft_isdigit(*line)) return (FALSE); - if ((tmp = ft_atoi(line)) > 255 || tmp < 0) + if ((tmp = ft_strtol(line, &line, 10)) > 255 || tmp < 0) return (FALSE); state->ceilling_color.rgb.b = (t_byte)tmp; + if (errno != 0) + return (FALSE); return (TRUE); } t_bool parse_floor_color(t_state *state, char *line) { - int tmp; + long tmp; + errno = 0; state->floor_color.hexcode = 0x0; - if ((tmp = ft_atoi(line)) > 255 || tmp < 0) + if ((tmp = ft_strtol(line, &line, 10)) > 255 || tmp < 0) return (FALSE); state->floor_color.rgb.r = (t_byte)tmp; - if ((line = ft_strchr(line, ',') + 1) == NULL) + if (*line++ != ',' || !ft_isdigit(*line)) return (FALSE); - if ((tmp = ft_atoi(line)) > 255 || tmp < 0) + if ((tmp = ft_strtol(line, &line, 10)) > 255 || tmp < 0) return (FALSE); state->floor_color.rgb.g = (t_byte)tmp; - if ((line = ft_strchr(line, ',') + 1) == NULL) + if (*line++ != ',' || !ft_isdigit(*line)) return (FALSE); - if ((tmp = ft_atoi(line)) > 255 || tmp < 0) + if ((tmp = ft_strtol(line, &line, 10)) > 255 || tmp < 0) return (FALSE); state->floor_color.rgb.b = (t_byte)tmp; + if (errno != 0) + return (FALSE); return (TRUE); } -- cgit