From 802ea8347d1ceb7a02cf279359b3b101106fab94 Mon Sep 17 00:00:00 2001 From: Charles Cabergs Date: Sat, 9 Jan 2021 16:07:01 +0100 Subject: Added separate thread to check if max meal num is reached independent from philosopher death --- philo_two/src/event.c | 19 +++++----------- philo_two/src/main.c | 57 ++++++++++++++++++++++++----------------------- philo_two/src/philo_two.h | 7 +++--- philo_two/src/routine.c | 7 +++--- 4 files changed, 41 insertions(+), 49 deletions(-) (limited to 'philo_two/src') diff --git a/philo_two/src/event.c b/philo_two/src/event.c index 3ce471e..2fc1249 100644 --- a/philo_two/src/event.c +++ b/philo_two/src/event.c @@ -6,7 +6,7 @@ /* By: cacharle +#+ +:+ +#+ */ /* +#+#+#+#+#+ +#+ */ /* Created: 2020/02/14 21:37:50 by cacharle #+# #+# */ -/* Updated: 2021/01/08 19:54:40 by charles ### ########.fr */ +/* Updated: 2021/01/09 15:18:24 by charles ### ########.fr */ /* */ /* ************************************************************************** */ @@ -14,7 +14,7 @@ void event_take_fork(t_philo *arg) { - sem_wait(arg->forks); + sem_wait(arg->conf->sem_forks); sem_wait(arg->conf->sem_stdout); philo_put(arg->id, EVENT_FORK, arg->conf->initial_time); sem_post(arg->conf->sem_stdout); @@ -40,23 +40,14 @@ void event_sleep(t_philo *arg) sem_wait(arg->conf->sem_stdout); philo_put(arg->id, EVENT_SLEEP, arg->conf->initial_time); sem_post(arg->conf->sem_stdout); - sem_post(arg->forks); - sem_post(arg->forks); + sem_post(arg->conf->sem_forks); + sem_post(arg->conf->sem_forks); h_sleep(arg->conf->timeout_sleep); } void event_die(t_philo *arg) { - long int i; - sem_wait(arg->conf->sem_stdout); philo_put(arg->id, EVENT_DIE, arg->conf->initial_time); - if (arg->conf->meal_num == -1) - sem_post(arg->conf->sem_finish); - else - { - i = -1; - while (++i < arg->conf->philo_num) - sem_post(arg->conf->sem_finish); - } + sem_post(arg->conf->sem_finish); } diff --git a/philo_two/src/main.c b/philo_two/src/main.c index 034518c..fb441dc 100644 --- a/philo_two/src/main.c +++ b/philo_two/src/main.c @@ -6,17 +6,18 @@ /* By: cacharle +#+ +:+ +#+ */ /* +#+#+#+#+#+ +#+ */ /* Created: 2020/02/14 22:45:23 by cacharle #+# #+# */ -/* Updated: 2021/01/08 20:16:20 by charles ### ########.fr */ +/* Updated: 2021/01/09 15:35:47 by charles ### ########.fr */ /* */ /* ************************************************************************** */ #include "philo_two.h" -#define PHILO_SEM_NAME "semaphore_philo_two" -#define PHILO_SEM_STDOUT_NAME "semaphore_philo_two_stdout" -#define PHILO_SEM_FINISH_NAME "semaphore_philo_two_finish" -#define PHILO_SEM_START_NAME "semaphore_philo_two_start" -#define PHILO_SEM_GRAB_NAME "semaphore_philo_two_grab" +#define PHILO_SEM_NAME "semaphore_philo_two" +#define PHILO_SEM_STDOUT_NAME "semaphore_philo_two_stdout" +#define PHILO_SEM_FINISH_NAME "semaphore_philo_two_finish" +#define PHILO_SEM_START_NAME "semaphore_philo_two_start" +#define PHILO_SEM_GRAB_NAME "semaphore_philo_two_grab" +#define PHILO_SEM_MEAL_NUM_NAME "semaphore_philo_two_meal_num" static int st_destroy( t_philo *philos, @@ -25,6 +26,7 @@ static int st_destroy( sem_unlink(PHILO_SEM_NAME); sem_unlink(PHILO_SEM_STDOUT_NAME); sem_unlink(PHILO_SEM_FINISH_NAME); + sem_unlink(PHILO_SEM_MEAL_NUM_NAME); sem_unlink(PHILO_SEM_START_NAME); sem_unlink(PHILO_SEM_GRAB_NAME); free(philos); @@ -53,20 +55,19 @@ void *routine_flush(t_philo_conf *conf) static int st_setup( t_philo_conf *conf, t_philo **philos, - sem_t **forks, pthread_t **threads) { long int i; - if (!st_sem_create(PHILO_SEM_NAME, conf->philo_num, forks) || + if (!st_sem_create(PHILO_SEM_NAME, conf->philo_num, &conf->sem_forks) || !st_sem_create(PHILO_SEM_STDOUT_NAME, 1, &conf->sem_stdout) || - !st_sem_create(PHILO_SEM_FINISH_NAME, - conf->meal_num == -1 ? 1 : conf->philo_num, &conf->sem_finish) || + !st_sem_create(PHILO_SEM_FINISH_NAME, 1, &conf->sem_finish) || + !st_sem_create(PHILO_SEM_MEAL_NUM_NAME, conf->philo_num, &conf->sem_meal_num) || !st_sem_create(PHILO_SEM_START_NAME, conf->philo_num, &conf->sem_start) || !st_sem_create(PHILO_SEM_GRAB_NAME, 1, &conf->sem_grab)) return (1); *threads = NULL; - if ((*philos = routine_create_philos(conf, *forks)) == NULL || + if ((*philos = routine_create_philos(conf)) == NULL || (*threads = malloc(sizeof(pthread_t) * conf->philo_num)) == NULL) return (st_destroy(*philos, *threads)); i = -1; @@ -90,24 +91,21 @@ static int st_setup( return (0); } -static void st_wait(t_philo_conf *conf) +static void *st_routine_meal_num(t_philo_conf *conf) { long int i; if (conf->meal_num == -1) - { - sem_wait(conf->sem_finish); - sem_wait(conf->sem_finish); - } - else - { - i = -1; - while (++i < conf->philo_num) - sem_wait(conf->sem_finish); - i = -1; - while (++i < conf->philo_num) - sem_wait(conf->sem_finish); - } + return (NULL); + i = -1; + while (++i < conf->philo_num) + sem_wait(conf->sem_meal_num); + i = -1; + while (++i < conf->philo_num) + sem_wait(conf->sem_meal_num); + sem_wait(conf->sem_stdout); + sem_post(conf->sem_finish); + return (NULL); } int main(int argc, char **argv) @@ -115,19 +113,22 @@ int main(int argc, char **argv) long int i; t_philo_conf conf; t_philo *philos; - sem_t *forks; pthread_t *threads; if (!parse_args((t_philo_args *)&conf, argc, argv)) return (1); if (conf.philo_num == 0 || conf.meal_num == 0) return (0); - if (st_setup(&conf, &philos, &forks, &threads) != 0) + if (st_setup(&conf, &philos, &threads) != 0) return (1); pthread_t thread_flush; pthread_create(&thread_flush, NULL, (t_routine)routine_flush, (void*)&conf); pthread_detach(thread_flush); - st_wait(&conf); + pthread_t thread_meal_num; + pthread_create(&thread_meal_num, NULL, (t_routine)st_routine_meal_num, (void*)&conf); + pthread_detach(thread_meal_num); + sem_wait(conf.sem_finish); + sem_wait(conf.sem_finish); philo_put_flush(); i = -1; while (++i < conf.philo_num) diff --git a/philo_two/src/philo_two.h b/philo_two/src/philo_two.h index 91cdbef..b2b723e 100644 --- a/philo_two/src/philo_two.h +++ b/philo_two/src/philo_two.h @@ -6,7 +6,7 @@ /* By: cacharle +#+ +:+ +#+ */ /* +#+#+#+#+#+ +#+ */ /* Created: 2020/02/14 22:47:23 by cacharle #+# #+# */ -/* Updated: 2021/01/08 20:10:36 by charles ### ########.fr */ +/* Updated: 2021/01/09 15:17:40 by charles ### ########.fr */ /* */ /* ************************************************************************** */ @@ -30,8 +30,10 @@ typedef struct t_time timeout_sleep; long int meal_num; t_time initial_time; + sem_t *sem_forks; sem_t *sem_stdout; sem_t *sem_finish; + sem_t *sem_meal_num; sem_t *sem_start; sem_t *sem_grab; } t_philo_conf; @@ -41,7 +43,6 @@ typedef struct long int id; t_philo_conf *conf; t_time time_last_eat; - sem_t *forks; } t_philo; /* @@ -50,7 +51,7 @@ typedef struct void *routine_philo(t_philo *arg); void *routine_death(t_philo *arg); -t_philo *routine_create_philos(t_philo_conf *conf, sem_t *forks); +t_philo *routine_create_philos(t_philo_conf *conf); /* ** io.c diff --git a/philo_two/src/routine.c b/philo_two/src/routine.c index 52bf53d..c491a0a 100644 --- a/philo_two/src/routine.c +++ b/philo_two/src/routine.c @@ -6,7 +6,7 @@ /* By: cacharle +#+ +:+ +#+ */ /* +#+#+#+#+#+ +#+ */ /* Created: 2020/02/14 23:00:07 by cacharle #+# #+# */ -/* Updated: 2021/01/08 20:18:00 by charles ### ########.fr */ +/* Updated: 2021/01/09 15:17:32 by charles ### ########.fr */ /* */ /* ************************************************************************** */ @@ -33,7 +33,7 @@ void *routine_philo(t_philo *arg) if (arg->conf->meal_num != -1 && ++eat_counter == arg->conf->meal_num) { sem_wait(arg->conf->sem_stdout); - sem_post(arg->conf->sem_finish); + sem_post(arg->conf->sem_meal_num); sem_post(arg->conf->sem_stdout); } event_sleep(arg); @@ -57,7 +57,7 @@ void *routine_death(t_philo *arg) return (NULL); } -t_philo *routine_create_philos(t_philo_conf *conf, sem_t *forks) +t_philo *routine_create_philos(t_philo_conf *conf) { int i; t_philo *philos; @@ -68,7 +68,6 @@ t_philo *routine_create_philos(t_philo_conf *conf, sem_t *forks) while (++i < conf->philo_num) { philos[i].id = i + 1; - philos[i].forks = forks; philos[i].conf = conf; } return (philos); -- cgit